mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coredump: kill mm->core_done
Date: Sat, 19 Jul 2008 20:20:01 -0700 (PDT)	[thread overview]
Message-ID: <20080720032001.E707315421D@magilla.localdomain> (raw)
In-Reply-To: Oleg Nesterov's message of  Tuesday, 15 July 2008 18:07:15 +0400 <20080715140715.GA25824@tv-sign.ru>

It is indeed ugly.  I think the place to start is with moving all the
coredump code out of exit_mm() into a new subfunction that is just passed
the mm pointer, and doing the same with coredump_finish() as you've done,
but leaving the completion logic inside those functions the same.  If all
references to the core_* fields in mm_struct are inside coredump_*()
functions, then that is a good basis for the future cleanups.


Thanks,
Roland

  parent reply	other threads:[~2008-07-20  3:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 14:07 Oleg Nesterov
2008-07-15 16:21 ` Oleg Nesterov
2008-07-15 22:44   ` Andrew Morton
2008-07-19 23:31 ` Johannes Weiner
2008-07-20  8:47   ` Oleg Nesterov
2008-07-20 11:35     ` Johannes Weiner
2008-07-20 12:37       ` Oleg Nesterov
2008-07-20 13:19         ` Johannes Weiner
2008-07-20  3:20 ` Roland McGrath [this message]
2008-07-20  8:51   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080720032001.E707315421D@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®