From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernelnewbies <kernelnewbies@nl.linux.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86-kernel: fix sparse warnings
Date: Mon, 21 Jul 2008 13:23:55 +0200 [thread overview]
Message-ID: <20080721112355.GA23095@elte.hu> (raw)
In-Reply-To: <1215879607.19076.36.camel@jaswinder.satnam>
* Jaswinder Singh <jaswinder@infradead.org> wrote:
> I am trying to solve following sparse warnings. Please give me feedback
> for the Patch. You can also find updated sparse patches from
> http://git.infradead.org/users/jaswinder/sparse-2.6.git
> 28 files changed, 140 insertions(+), 18 deletions(-)
nice.
Could you please split this up into individual commits, and against
tip/master:
http://people.redhat.com/mingo/tip.git/README
Granularity should be roughly per file. (i.e. around 30 commits would be
fine) That way if any commit is found to be bad we can unapply/revert it
just fine without the rest of your changes. Merging into different topic
branches is also easier that way.
Ingo
prev parent reply other threads:[~2008-07-21 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 16:20 Jaswinder Singh
2008-07-21 11:23 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721112355.GA23095@elte.hu \
--to=mingo@elte.hu \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=jaswinder@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®