From: Mark Fasheh <mfasheh@suse.com>
To: Julia Lawall <julia@diku.dk>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/7] fs/ocfs2/file.c: Release mutex in error handling code
Date: Mon, 21 Jul 2008 17:07:12 -0700 [thread overview]
Message-ID: <20080722000711.GT28014@wotan.suse.de> (raw)
In-Reply-To: <20080721203608.GB31671@ca-server1.us.oracle.com>
On Mon, Jul 21, 2008 at 01:36:08PM -0700, Joel Becker wrote:
> On Mon, Jul 21, 2008 at 09:59:15AM +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > The mutex is released on a successful return, so it would seem that it
> > should be released on an error return as well.
>
> This patch looks right to me. Mark?
Yeah, that looks good. Thanks Julia.
--Mark
--
Mark Fasheh
prev parent reply other threads:[~2008-07-22 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 7:59 Julia Lawall
2008-07-21 20:36 ` Joel Becker
2008-07-22 0:07 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722000711.GT28014@wotan.suse.de \
--to=mfasheh@suse.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®