From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbYGVIYo (ORCPT ); Tue, 22 Jul 2008 04:24:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752209AbYGVIYa (ORCPT ); Tue, 22 Jul 2008 04:24:30 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:51681 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbYGVIY3 (ORCPT ); Tue, 22 Jul 2008 04:24:29 -0400 Date: Tue, 22 Jul 2008 10:24:10 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Paul Jackson , Mike Travis , Thomas Gleixner , "H. Peter Anvin" , Suresh Siddha , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: add apic probe for genapic 64bit v2 Message-ID: <20080722082410.GB2065@elte.hu> References: <200807211836.27282.yhlu.kernel@gmail.com> <200807212208.22116.yhlu.kernel@gmail.com> <20080722070734.GA16085@elte.hu> <20080722071324.GA2664@elte.hu> <86802c440807220109s63307f28uc0658402cb26cfea@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86802c440807220109s63307f28uc0658402cb26cfea@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > On Tue, Jul 22, 2008 at 12:13 AM, Ingo Molnar wrote: > > > > * Ingo Molnar wrote: > > > >> > v2: fix compiling when CONFIG_ACPI is not set > >> > >> applied to tip/x86/x2apic - thanks Yinghai. > >> > >> > +static struct genapic *apic_probe[] __initdata = { > >> > + &apic_x2apic_uv_x, > >> > + &apic_x2apic_phys, > >> > + &apic_x2apic_cluster, > >> > + &apic_physflat, > >> > + NULL, > >> > +}; > >> > >> very nice generalization! > > > > btw.: > > > > apic_probe[i]->acpi_madt_oem_check > > > > should probably be renamed to something more neutral like "->probe" - > > there's nothing ACPI about it and some weird boxes could use PCI or > > other probing mechanisms to discover the type of APIC they want to use. > > 32bit has acpi_madt_oem_check and mps_oem_check > 64bit should only have acpi_madt_oem_check yeah. It's just a small detail: what i mean is that the method itself should eventually simply be renamed from "acpi_madt_oem_check" to "probe". There's nothing ACPI about this exept the fact that most current "is this the APIC driver we should be using" checks involve some sort of ACPI discovery. This is a Linux abstraction and as such a more generic name like "probe" sounds more appropriate. Ingo