From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com
Subject: Re: [Patch] um: fix a build error
Date: Tue, 22 Jul 2008 11:53:54 +0100 [thread overview]
Message-ID: <20080722115354.79ba2314@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080722105812.GB5283@alice>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6/arch/um/drivers/line.c.orig 2008-07-22 12:06:17.000000000 +0200
> +++ linux-2.6/arch/um/drivers/line.c 2008-07-22 12:06:49.000000000 +0200
> @@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt(
> if (tty == NULL)
> return IRQ_NONE;
>
> - if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
> - (tty->ldisc.write_wakeup != NULL))
> - (tty->ldisc.write_wakeup)(tty);
> -
> + if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
> + tty_wakeup(tty);
Sorry I should have been clearer - you don't want the test_bit either.
Acked-by: Alan Cox <alan@redhat.com>
however as it is still right but you can stick my Ack on a version
without the if too.
next prev parent reply other threads:[~2008-07-22 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 10:58 Eric Sesterhenn
2008-07-22 10:53 ` Alan Cox [this message]
2008-07-22 11:25 ` WANG Cong
2008-07-22 17:35 ` WANG Cong
2008-07-22 17:42 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2008-07-21 16:54 WANG Cong
2008-07-21 16:32 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722115354.79ba2314@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®