From: Ingo Oeser <ioe-lkml@rameria.de>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] set_irq_wake: fix return code and wake status tracking
Date: Wed, 23 Jul 2008 20:44:14 +0200 [thread overview]
Message-ID: <200807232044.15049.ioe-lkml@rameria.de> (raw)
In-Reply-To: <1216816945-20223-1-git-send-email-Uwe.Kleine-Koenig@digi.com>
Hi Uwe,
you can mark the new function static.
[trimmed CC list, since this is just a minor issue]
On Wednesday 23 July 2008, Uwe Kleine-König wrote:
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e01ad8e..227cd49 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -194,6 +194,17 @@ void enable_irq(unsigned int irq)
> }
> EXPORT_SYMBOL(enable_irq);
>
> +int set_irq_wake_real(unsigned int irq, unsigned int on)
static int set_irq_wake_real(unsigned int irq, unsigned int on)
> +{
> + struct irq_desc *desc = irq_desc + irq;
> + int ret = -ENXIO;
> +
> + if (desc->chip->set_wake)
> + ret = desc->chip->set_wake(irq, on);
> +
> + return ret;
> +}
> +
Best Regards
Ingo Oeser
next prev parent reply other threads:[~2008-07-23 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 12:42 Uwe Kleine-König
2008-07-23 16:00 ` David Brownell
2008-07-23 18:44 ` Ingo Oeser [this message]
2008-07-24 5:42 ` Uwe Kleine-König
2008-07-24 5:51 ` [PATCH] make set_irq_wake_real static Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807232044.15049.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®