mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wedgwood <cw@f00f.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH {1,3}/7] ata: add missing ATA_CMD_* defines
Date: Wed, 23 Jul 2008 16:52:37 -0700	[thread overview]
Message-ID: <20080723235237.GA11354@puku.stupidest.org> (raw)
In-Reply-To: <200807232042.45733.bzolnier@gmail.com> <200807232040.18264.bzolnier@gmail.com>

On Wed, Jul 23, 2008 at 08:40:18PM +0200, Bartlomiej Zolnierkiewicz wrote:

> Add missing ATA_CMD_* defines to <linux/ata.h>.  Also add
> ATA_EXABYTE_ENABLE_NEST, SETFEATURES_AAM_* and ATA_SMART_*
> defines while at it.
>
> Partially based on earlier work by Chris Wedgwood.

[...]


On Wed, Jul 23, 2008 at 08:42:45PM +0200, Bartlomiej Zolnierkiewicz wrote:
> * Use ATA_CMD_* defines instead of WIN_* ones.
>
> While at it:
>
> * EXABYTE_ENABLE_NEXT -> ATA_EXABYTE_ENABLE_NEST
>
> * SETFEATURES_{EN,DIS}_WCACHE -> SETFEATURES_WC_{ON,OFF}
>
> * SETFEATURES_{EN,DIS}_AAM -> SETFEATURES_AAM_{ON,OFF}
>
> * SMART_* -> ATA_SMART_*
>
> * Remove stale comment from ide-proc.c.
>
> Partially based on earlier work by Chris Wedgwood.

ACK/signoff from me (in so far as it's relevant, my original patches
are so old I'm sure Bart probably had to so it almost all again).

  parent reply	other threads:[~2008-07-24  0:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 18:42 [PATCH 3/7] ide: WIN_* -> ATA_CMD_* Bartlomiej Zolnierkiewicz
2008-07-23 18:40 ` [PATCH 1/7] ata: add missing ATA_CMD_* defines Bartlomiej Zolnierkiewicz
2008-07-23 20:46   ` Jeff Garzik
2008-07-23 23:52   ` Chris Wedgwood [this message]
2008-07-24 19:07     ` [PATCH {1,3}/7] " Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080723235237.GA11354@puku.stupidest.org \
    --to=cw@f00f.org \
    --cc=bzolnier@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®