From: David Miller <davem@davemloft.net>
To: heiko.carstens@de.ibm.com
Cc: frank.blaschka@de.ibm.com, schwidefsky@de.ibm.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [BUG] qeth doesn't work anymore because of netdev_priv changes
Date: Thu, 24 Jul 2008 13:56:02 -0700 (PDT) [thread overview]
Message-ID: <20080724.135602.196740386.davem@davemloft.net> (raw)
In-Reply-To: <20080724184624.GB8969@osiris.boeblingen.de.ibm.com>
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Thu, 24 Jul 2008 20:46:24 +0200
> git commit e3c50d5d25ac09efd9acbe2b2a3e365466de84ed
> "netdev: netdev_priv() can now be sane again." breaks qeth on s390
> (no more networking possible). Reverting the patch fixes it.
> I haven't looked into this any further.
You guys have to stop overriding netdev->priv if that's what
you're doing.
If you need a mid-layer private pointer, use netdev->ml_priv
as it's created exactly for that purpose.
next prev parent reply other threads:[~2008-07-24 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 18:46 Heiko Carstens
2008-07-24 20:56 ` David Miller [this message]
2008-07-25 1:57 ` Heiko Carstens
2008-07-26 9:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724.135602.196740386.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=frank.blaschka@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®