Re: [PATCH] Let HP iLO driver depend on PCI

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 25 Jul 2008 04:20:48 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> Subject: [PATCH] Let HP iLO driver depend on PCI
> 
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> "HP iLO driver" causes this on s390:
> 
> drivers/misc/hpilo.c: In function 'doorbell_set':
> drivers/misc/hpilo.c:147: error: implicit declaration of function 'iowrite8'
> drivers/misc/hpilo.c: In function 'ilo_ccb_close':
> drivers/misc/hpilo.c:204: error: implicit declaration of function 'iowrite32'
> drivers/misc/hpilo.c:204: error: implicit declaration of function 'ioread32'
> drivers/misc/hpilo.c:222: error: implicit declaration of function 'memset_io'
> drivers/misc/hpilo.c:225: error: implicit declaration of function 'pci_free_consistent'
> drivers/misc/hpilo.c: In function 'ilo_ccb_open':
> drivers/misc/hpilo.c:244: error: implicit declaration of function 'pci_alloc_consistent'
> drivers/misc/hpilo.c:245: warning: assignment makes pointer from integer without a cast
> drivers/misc/hpilo.c:296: error: implicit declaration of function 'memcpy_toio'
> drivers/misc/hpilo.c: In function 'ilo_unmap_device':
> drivers/misc/hpilo.c:575: error: implicit declaration of function 'pci_iounmap'
> drivers/misc/hpilo.c: In function 'ilo_map_device':
> drivers/misc/hpilo.c:585: error: implicit declaration of function 'pci_iomap'
> drivers/misc/hpilo.c:585: warning: assignment makes pointer from integer without a cast
> drivers/misc/hpilo.c:592: warning: assignment makes pointer from integer without a cast
> drivers/misc/hpilo.c:599: warning: assignment makes pointer from integer without a cast
> make[2]: *** [drivers/misc/hpilo.o] Error 1
> 
> Just let it depend on PCI.

Yeah, I already queued up the same patch as
drivers-misc-hpiloc-needs-config_pci.patch

Three weeks and nobody did an allmodconfig build on linux-next for s390
or m68k (at least).