From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: Trond.Myklebust@netapp.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.26-git] Fix oops on remounting nfsroot
Date: Fri, 25 Jul 2008 23:59:19 +0900 (JST) [thread overview]
Message-ID: <20080725.235919.36921137.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <1216934983.7171.1.camel@localhost>
On Thu, 24 Jul 2008 14:29:43 -0700, Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> > + if (!options ||
> > + (nfsvers == 4 && options4->version == 1) ||
> > (nfsvers <= 3 && options->version >= 1 &&
> > options->version <= 6))
> > return 0;
>
> The above is almost correct. You need to test for options4 if the
> filesystem is NFSv4.
But options == options4 == raw_data ;)
> Marc Zyngier sent me a patch for the same problem a couple of days ago,
> but I have yet to pass it on to Linus.
OK, I'll wait that patch merged. Thanks.
---
Atsushi Nemoto
prev parent reply other threads:[~2008-07-25 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 9:51 Atsushi Nemoto
2008-07-24 21:29 ` Trond Myklebust
2008-07-25 14:59 ` Atsushi Nemoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725.235919.36921137.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®