mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: viro@ZenIV.linux.org.uk, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: [patch] Re: [bug, build failure] Re: [PATCH] missing bits of net-namespace / sysctl
Date: Sun, 27 Jul 2008 23:42:50 +0200	[thread overview]
Message-ID: <20080727214250.GA5917@elte.hu> (raw)
In-Reply-To: <20080727213905.GA4499@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> hmmm:
> 
> net/ipv4/route.c: In function 'ip_static_sysctl_init':
> net/ipv4/route.c:3225: error: 'ipv4_route_path' undeclared (first use in this function)
> net/ipv4/route.c:3225: error: (Each undeclared identifier is reported only once
> net/ipv4/route.c:3225: error: for each function it appears in.)
> net/ipv4/route.c:3225: error: 'ipv4_route_table' undeclared (first use in this function)
>  
> 64-bit x86 config attached.

minimal fix is below.

	Ingo

>From b8406d18c942261bc98b3b749204881b52ef7d18 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 27 Jul 2008 23:51:45 +0200
Subject: [PATCH] net/ipv4/route.c: fix build error

fix:

net/ipv4/route.c: In function 'ip_static_sysctl_init':
net/ipv4/route.c:3225: error: 'ipv4_route_path' undeclared (first use in this function)
net/ipv4/route.c:3225: error: (Each undeclared identifier is reported only once
net/ipv4/route.c:3225: error: for each function it appears in.)
net/ipv4/route.c:3225: error: 'ipv4_route_table' undeclared (first use in this function)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 net/ipv4/route.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 380d647..d7bf056 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -3222,7 +3222,9 @@ int __init ip_rt_init(void)
  */
 void __init ip_static_sysctl_init(void)
 {
+#ifdef CONFIG_SYSCTL
 	register_sysctl_paths(ipv4_route_path, ipv4_route_table);
+#endif
 }
 
 EXPORT_SYMBOL(__ip_select_ident);

      reply	other threads:[~2008-07-27 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-27  7:59 Al Viro
2008-07-27 11:41 ` David Miller
2008-07-27 21:39   ` [bug, build failure] " Ingo Molnar
2008-07-27 21:42     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080727214250.GA5917@elte.hu \
    --to=mingo@elte.hu \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®