mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	dahinds@users.sourceforge.net, becker@scyld.com,
	x-csrdh@jcu.edu.au, erik@vt.edu, Jeff Garzik <jeff@garzik.org>,
	netdev <netdev@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] smc91c92_cs: use request_firmware
Date: Mon, 28 Jul 2008 10:28:14 +0200	[thread overview]
Message-ID: <20080728082814.GA4708@isilmar.linta.de> (raw)
In-Reply-To: <1217170341.3537.9.camel@jaswinder.satnam>

Hi,

On Sun, Jul 27, 2008 at 08:22:21PM +0530, Jaswinder Singh wrote:
> +static int osi_load_firmware(struct pcmcia_device *link)
> +{
> +	struct platform_device *pdev;
> +	const struct firmware *fw;
> +	const char fw_name[] = "ositech/Xilinx7OD.bin"; 
> +	int i, err;
> + 
> +	pdev = platform_device_register_simple("ositech", 0, NULL, 0);

Why do we need a platform_device here? Can't we just use the pcmcia device
(so &link->dev) here?

Thanks,
	Dominik

  reply	other threads:[~2008-07-28  8:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-27 14:52 Jaswinder Singh
2008-07-28  8:28 ` Dominik Brodowski [this message]
2008-07-28  9:02   ` Jaswinder Singh
2008-07-28  9:07     ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728082814.GA4708@isilmar.linta.de \
    --to=linux@dominikbrodowski.net \
    --cc=becker@scyld.com \
    --cc=dahinds@users.sourceforge.net \
    --cc=dwmw2@infradead.org \
    --cc=erik@vt.edu \
    --cc=jaswinder@infradead.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=x-csrdh@jcu.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®