mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
	Alex Chiang <achiang@hp.com>, LKML <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org,
	Kristen Accardi <kristen.c.accardi@intel.com>
Subject: Re: post 2.6.26 requires pciehp_slot_with_bus
Date: Mon, 28 Jul 2008 09:16:44 -0700	[thread overview]
Message-ID: <200807280916.44664.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <488D86EC.1010903@jp.fujitsu.com>

On Monday, July 28, 2008 1:44 am Kenji Kaneshige wrote:
> Jesse Barnes wrote:
> > I think that's fine (automatically creating duplicate devices with names
> > to differentiate them), but I think we should also try harder to avoid
> > adding duplicates.
> >
> > In Pierre's case, and on my T61, there's only one actual hotplug slot
> > available, but the firmware creates duplicate physical slot numbers and
> > sets the HP_CAP bit on everything, both of which are obviously wrong
> > (well I suppose you could pop these chips off the board, but it's not
> > very practical).  However, afaict that "other" OS uses the _RMV method to
> > determine whether a given slot is actually hot pluggable.  On my T61 at
> > least, this seems to be accurate: only one of my EXP* objects has a _RMV
> > method.
> >
> > So maybe the PCIe hotplug driver should be checking for that method when
> > ACPI is available?  We already try to use _OSC etc., so checking for _RMV
> > first would make sense...
>
> As you pointed out, the root cause might not a problem of slot naming,
> but a problem of slots detection, because pciehp driver detects multiple
> PCIe hotplug slots even thought your and Pierre's system seems to have
> only one hotplug slot. So I think we should also consider the problem
> from this view point (slot detection).
>
> But, I think simply checking for _RMV method first is dangerous because
> I think there are many systems that doesn't implement _RMV for PCIe
> hotplug slots (at least, my system doesn't implement that. Anyway,
> I would like to look at the documents/specifications that mention _RMV
> method for determining whether a given slot is hot pluggable. Do you
> have any information about that? I think PCI Local Bus, PCI Express and
> PCI Firmware specification don't mention that. I think hot pluggable slots
> on your, Pierre's and Matthew's system are ExpressCard slots. So I guess
> ExpressCard specification might define something about this. But
> unfortunately, I don't have ExpressCard specification. Can anyone access
> ExpressCard spec?

Your systems don't have _RMV methods for the hotpluggable PCIe slots in the 
DSDT?  That's a shame; the Windows docs I found on PCIe hotplug seemed to 
indicate that _RMV and _OSC (under Vista) were used to detect whether a given 
slot was hot pluggable (I just googled for "windows pcie hotplug" or 
something) so I was hoping that would be a reliable method...  Any other 
ideas?  I'll go see if I can dig up some ExpressCard info.

Thanks,
Jesse

  reply	other threads:[~2008-07-28 16:17 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 11:47 Pierre Ossman
2008-07-24 12:38 ` Kenji Kaneshige
2008-07-24 20:39   ` Pierre Ossman
2008-07-24 21:07     ` Jesse Barnes
2008-07-24 21:51       ` Pierre Ossman
2008-07-24 22:06         ` Jesse Barnes
2008-07-24 22:29           ` Alex Chiang
2008-07-24 22:49             ` Pierre Ossman
2008-07-24 23:08               ` Alex Chiang
2008-07-24 23:29                 ` Pierre Ossman
2008-07-25  3:29                   ` Matthew Wilcox
2008-07-25  4:42                     ` Alex Chiang
2008-07-25  5:38                       ` Kenji Kaneshige
2008-07-25 11:18                         ` Matthew Wilcox
2008-07-28 18:05                       ` Greg KH
2008-07-25  4:57                     ` Kenji Kaneshige
2008-07-30  2:38                       ` Alex Chiang
2008-07-30  2:42                         ` [PATCH 1/2] pciehp: Rename duplicate slot name N as N-1, N-2, N-M Alex Chiang
2008-07-31 10:32                           ` Kenji Kaneshige
2008-07-30  2:44                         ` [PATCH 2/2] shpchp: " Alex Chiang
2008-07-31 10:32                           ` Kenji Kaneshige
2008-07-31 10:31                         ` post 2.6.26 requires pciehp_slot_with_bus Kenji Kaneshige
2008-07-31 15:47                           ` Alex Chiang
2008-08-01  8:43                             ` Kenji Kaneshige
2008-07-25  8:53                     ` Kenji Kaneshige
2008-07-25 11:40                       ` Matthew Wilcox
2008-07-28  7:21                         ` Kenji Kaneshige
2008-07-25  4:50                   ` Kenji Kaneshige
2008-07-25 22:18                     ` Jesse Barnes
2008-07-26  1:16                       ` Matthew Wilcox
2008-07-28  8:58                         ` Kenji Kaneshige
2008-07-28  8:44                       ` Kenji Kaneshige
2008-07-28 16:16                         ` Jesse Barnes [this message]
2008-07-29  2:43                           ` Kenji Kaneshige
2008-07-29 15:14                             ` Jesse Barnes
2008-07-30  2:44                               ` Kenji Kaneshige
2008-07-28 16:57                         ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807280916.44664.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=achiang@hp.com \
    --cc=drzeus-list@drzeus.cx \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome