From: Ingo Molnar <mingo@elte.hu>
To: Joe Perches <joe@perches.com>
Cc: Rabin Vincent <rabin@rab.in>, lkml <linux-kernel@vger.kernel.org>,
akataria@vmware.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Remove stray <6> in BogoMIPS printk
Date: Mon, 28 Jul 2008 14:24:01 +0200 [thread overview]
Message-ID: <20080728122401.GB5515@elte.hu> (raw)
In-Reply-To: <1217185324.6056.19.camel@localhost>
* Joe Perches <joe@perches.com> wrote:
> On Sun, 2008-07-27 at 23:47 +0530, Rabin Vincent wrote:
> > Remove the extra KERN_INFO which causes this:
> > Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
> > - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> > - loops_per_jiffy/(500000/HZ),
> > - (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> > + printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
> > + loops_per_jiffy/(500000/HZ),
> > + (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> > }
>
> How about just using KERN_CONT and leaving the whitespace
> for a patch that does the entire file?
>
> diff --git a/init/calibrate.c b/init/calibrate.c
> index 7963e3f..51c5cec 100644
> --- a/init/calibrate.c
> +++ b/init/calibrate.c
> @@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
> loops_per_jiffy &= ~loopbit;
> }
> }
> - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> + printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> loops_per_jiffy/(500000/HZ),
> (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
ok - i've applied the patch below. Please send the full-file cleanup as
a separate patch if anyone is interested in doing it.
Ingo
------------>
>From d7ba11d01cfedf63b50391fbe4a05274b6992b43 Mon Sep 17 00:00:00 2001
From: Joe Perches <joe@perches.com>
Date: Sun, 27 Jul 2008 12:02:04 -0700
Subject: [PATCH] x86: remove stray <6> in BogoMIPS printk
Rabin Vincent noticed that there's a stray <6> in BogoMIPS printk:
> Remove the extra KERN_INFO which causes this:
> Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
> - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> - loops_per_jiffy/(500000/HZ),
> - (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> + printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
> + loops_per_jiffy/(500000/HZ),
> + (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> }
How about just using KERN_CONT and leaving the whitespace
for a patch that does the entire file?
Reported-by: Rabin Vincent <rabin@rab.in>
---
init/calibrate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/init/calibrate.c b/init/calibrate.c
index 7963e3f..a379c90 100644
--- a/init/calibrate.c
+++ b/init/calibrate.c
@@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
loops_per_jiffy &= ~loopbit;
}
}
- printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
+ printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
loops_per_jiffy/(500000/HZ),
(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
}
prev parent reply other threads:[~2008-07-28 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 18:17 Rabin Vincent
2008-07-27 19:02 ` Joe Perches
2008-07-28 12:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728122401.GB5515@elte.hu \
--to=mingo@elte.hu \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®