mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Alex Nixon (Intern)" <Alex.Nixon@eu.citrix.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] xen: xen: compile irq functions without -pg for ftrace
Date: Mon, 28 Jul 2008 21:32:35 +0200	[thread overview]
Message-ID: <20080728193235.GB11431@uranus.ravnborg.org> (raw)
In-Reply-To: <488E15C5.3070902@goop.org>

On Mon, Jul 28, 2008 at 11:53:57AM -0700, Jeremy Fitzhardinge wrote:
> For some reason I managed to miss a bunch of irq-related functions
> which also need to be compiled without -pg when using ftrace.  This
> patch moves them into their own file, and starts a cleanup process
> I've been meaning to do anyway.
> 
> [ Sam, Ingo: I think the problem was that I enabled CONFIG_FTRACE
>  but didn't do a clean build.  Shouldn't the build-system notice
>  that the config changes the CFLAGS and rebuild everything?  That
>  didn't seem to happen in this case. ]

The build system usually does this.
And I have no reports that this has regressed until now.
What file?
Can you tell me how to reproduce it?

> 
> ===================================================================
> --- a/arch/x86/xen/Makefile
> +++ b/arch/x86/xen/Makefile
> @@ -2,9 +2,10 @@
> # Do not profile debug and lowlevel utilities
> CFLAGS_REMOVE_spinlock.o = -pg
> CFLAGS_REMOVE_time.o = -pg
> +CFLAGS_REMOVE_irq.o = -pg
> endif

I already NACK'ed this syntax and described the way it should be done.
Is this ignored or on a TODO list?

	Sam

  reply	other threads:[~2008-07-28 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 18:53 Jeremy Fitzhardinge
2008-07-28 19:32 ` Sam Ravnborg [this message]
2008-07-28 19:50   ` Jeremy Fitzhardinge
2008-07-31 10:39 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728193235.GB11431@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Alex.Nixon@eu.citrix.com \
    --cc=ehabkost@redhat.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®