From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: combinatorial explosion in lockdep
Date: Tue, 29 Jul 2008 01:51:33 +0200 [thread overview]
Message-ID: <20080728235133.GA7956@elte.hu> (raw)
In-Reply-To: <20080728.161318.38361710.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 28 Jul 2008 15:37:02 -0700 (PDT)
>
> > I'm still digging on what exactly makes this happen, but I wanted to
> > get the information out as soon as I had something useful like this.
>
> As a simple hack, I tried mitigating these effects using a
> generation-count based "visited" scheme to bypass traversing
> lock_class chains we've already walked down.
>
> It seems to work.
nice!
Any chance to get the "cat /proc/lockdep*" output, so that we could see
and check the expected behavior of the full graph?
But with 128 cpus and double locking taking in the scheduler, there's
around 127*128/2 possible combinations of cpu rq lock ordering, that's
thousands of chains, and that takes a quadratic number of steps to
iterate via the current algorithm - which would be in the neighborhood
of 127^4 / 4, or about 65 million steps for each new change to the
graph. (but it's late and i'm not sure at all about the numbers so i
could be off by a few orders of magnitude, in either direction)
Plus the irqsafe/softirqsafe layers multiply things too.
Could you please also send the non-stack-iterator changes you did as
well - that's cool stuff too!
Ingo
next prev parent reply other threads:[~2008-07-28 23:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 22:37 David Miller
2008-07-28 22:50 ` Jeremy Fitzhardinge
2008-07-28 22:56 ` David Miller
2008-07-28 23:13 ` David Miller
2008-07-28 23:51 ` Ingo Molnar [this message]
2008-07-29 0:44 ` David Miller
2008-07-30 4:45 ` David Miller
2008-07-30 6:56 ` David Miller
2008-07-30 7:21 ` Peter Zijlstra
2008-07-30 7:19 ` Peter Zijlstra
2008-07-30 11:15 ` Peter Zijlstra
2008-07-31 16:50 ` [stable] " Greg KH
2008-07-30 11:26 ` [PATCH] lockdep: change scheduler annotation Peter Zijlstra
2008-07-30 11:34 ` David Miller
2008-07-31 16:34 ` Ingo Molnar
2008-07-31 16:39 ` combinatorial explosion in lockdep Ingo Molnar
2008-08-01 9:22 ` Ingo Molnar
2008-08-01 9:32 ` David Miller
2008-08-01 11:57 ` Hugh Dickins
2008-08-03 8:14 ` David Miller
2008-08-04 12:21 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728235133.GA7956@elte.hu \
--to=mingo@elte.hu \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome