From: Andrew Morton <akpm@linux-foundation.org>
To: Sven Wegener <sven.wegener@stealer.net>
Cc: Richard Purdie <rpurdie@rpsys.net>, Rod Whitby <rod@whitby.id.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds-fsg: Change order of initialization and deinitialization
Date: Wed, 30 Jul 2008 00:58:53 -0700 [thread overview]
Message-ID: <20080730005853.3f343d93.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0807272016570.16340@titan.stealer.net>
On Sun, 27 Jul 2008 20:30:59 +0200 (CEST) Sven Wegener <sven.wegener@stealer.net> wrote:
> --- a/drivers/leds/leds-fsg.c
> +++ b/drivers/leds/leds-fsg.c
> @@ -161,6 +161,16 @@ static int fsg_led_probe(struct platform_device *pdev)
> {
> int ret;
>
> + /* Map the LED chip select address space */
> + latch_address = (unsigned short *) ioremap(IXP4XX_EXP_BUS_BASE(2), 512);
> + if (!latch_address) {
> + ret = -ENOMEM;
> + goto failremap;
> + }
> +
> + latch_value = 0xffff;
> + *latch_address = latch_value;
Mutter. Shouldn't this driver be using readw/writew? It's not even
using a volatile pointer, so there's a decent risk that the compiler
will optimise away important things..
next prev parent reply other threads:[~2008-07-30 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 18:30 Sven Wegener
2008-07-27 23:43 ` Rod Whitby
2008-07-30 7:58 ` Andrew Morton [this message]
2008-07-30 15:42 ` Sven Wegener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730005853.3f343d93.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rod@whitby.id.au \
--cc=rpurdie@rpsys.net \
--cc=sven.wegener@stealer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome