From: Adrian Bunk <adrian.bunk@movial.fi>
To: Tim Bird <tim.bird@am.sony.com>
Cc: Marco Berizzi <pupilla@hotmail.com>,
Alistair John Strachan <alistair@devzero.co.uk>,
linux-kernel@vger.kernel.org, dwmw2@infradead.org,
Grant Coady <grant_lkml@dodo.com.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [RFT: 2.6 patch] fix text console corruptions
Date: Wed, 30 Jul 2008 17:06:55 +0300 [thread overview]
Message-ID: <20080730140655.GC19966@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <488FAFE3.4040001@am.sony.com>
On Tue, Jul 29, 2008 at 05:03:47PM -0700, Tim Bird wrote:
> Marco Berizzi wrote:
> > alistair@devzero.co.uk wrote:
> >
> >> You don't actually say whether you had CONFIG_CONSOLE_TRANSLATIONS=y or not?
> >
> > yes console_translation is set to yes. It cannot be changed if embedded is not
> > set.
>
> If console_translation is set to yes, the behavior should be unchanged from
> 2.6.26.
>...
Your commit contains a change that breaks due to | having a higher
precedence than ?: in C.
Untested patch below, can anyone who ran into this bug confirm that
it fixes it?
> Thanks,
> -- Tim
cu
Adrian
<-- snip -->
This patch fixes text console corruptions caused by
commit a29ccf6f823a84d89e1c7aaaf221cf7282022024
(Make console charset translation optional).
Reported-by: Marco Berizzi <pupilla@hotmail.com>
Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
---
cab22ec7afdc4c08a10ef9730b0ae2848754532c
diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
index 14c0e91..8c8119f 100644
--- a/include/linux/vt_kern.h
+++ b/include/linux/vt_kern.h
@@ -74,7 +74,7 @@ void con_protect_unimap(struct vc_data *vc, int rdonly);
int con_copy_unimap(struct vc_data *dst_vc, struct vc_data *src_vc);
#define vc_translate(vc, c) ((vc)->vc_translate[(c) | \
- (vc)->vc_toggle_meta ? 0x80 : 0])
+ ((vc)->vc_toggle_meta ? 0x80 : 0)])
#else
#define con_set_trans_old(arg) (0)
#define con_get_trans_old(arg) (-EINVAL)
next prev parent reply other threads:[~2008-07-30 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 15:42 commit a29ccf6f823a84d89e1c7aaaf221cf7282022024 break console on slackware 12.1 Marco Berizzi
2008-07-29 17:15 ` Alistair John Strachan
2008-07-29 18:57 ` Marco Berizzi
2008-07-30 0:03 ` Tim Bird
2008-07-30 0:30 ` Grant Coady
2008-07-30 20:11 ` Tim Bird
2008-07-30 23:47 ` Grant Coady
2008-07-31 11:02 ` Marco Berizzi
2008-07-30 21:54 ` Rene Herman
2008-07-30 23:40 ` Grant Coady
2008-07-30 1:16 ` Grant Coady
2008-07-30 6:36 ` Marco Berizzi
2008-07-30 14:06 ` Adrian Bunk [this message]
2008-07-30 15:24 ` [RFT: 2.6 patch] fix text console corruptions David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730140655.GC19966@cs181140183.pp.htv.fi \
--to=adrian.bunk@movial.fi \
--cc=akpm@linux-foundation.org \
--cc=alistair@devzero.co.uk \
--cc=dwmw2@infradead.org \
--cc=grant_lkml@dodo.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pupilla@hotmail.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®