From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eugeniy Meshcheryakov <eugen@debian.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] try harder to load tty ldisc driver
Date: Wed, 30 Jul 2008 23:51:30 +0100 [thread overview]
Message-ID: <20080730235130.32d36046@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080729204512.GA6242@localhost.localdomain>
On Tue, 29 Jul 2008 22:45:12 +0200
Eugeniy Meshcheryakov <eugen@debian.org> wrote:
> Currently function tty_ldisc_get() tries to load an ldisc driver module
> only when tty_ldisc_try_get() returns -EAGAIN. This happens only if
> module is being unloaded. If ldisc module is not loaded
> tty_ldisc_try_get() returns -EINVAL and this case is not handled in
> tty_ldisc_get(), so request_module() is not called.
>
> Attached patch fixes this by calling request_module() if
> tty_ldisc_try_get() returned any error code.
>
> I discovered this when my UMTS modem stopped working with 2.6.27-rc1
> because module ppp_async was not loaded.
>
> Signed-off-by: Eugeniy Meshcheryakov <eugen@debian.org>
Signed-off-by: Alan Cox <alan@redhat.com>
(And forwarded to the stable tree too)
prev parent reply other threads:[~2008-07-30 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 20:45 Eugeniy Meshcheryakov
2008-07-30 22:51 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730235130.32d36046@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=eugen@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®