From: Stephen Rothwell <sfr@canb.auug.org.au>
To: eranian@gmail.com
Cc: "stephane eranian" <eranian@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 00/19] perfmon2 minimal v3: introduction
Date: Thu, 31 Jul 2008 10:21:54 +1000 [thread overview]
Message-ID: <20080731102154.b06476dd.sfr@canb.auug.org.au> (raw)
In-Reply-To: <7c86c4470807301659t232a8dabw5272988d164898e@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
Hi Stephane,
On Wed, 30 Jul 2008 16:59:34 -0700 "stephane eranian" <eranian@googlemail.com> wrote:
>
> On Mon, Jul 28, 2008 at 11:20 PM, stephane eranian
> <eranian@googlemail.com> wrote:
> >> quite a few of the macros (especially for the dummy (non
> >> CONFIG_PERFMON) versions of functions) should be "static inline"
> >> functions unless they absolutely must be macros. Andrew Morton said it
> >> best - "write in C not C preprocessor".
> >>
> Do you also have a problem with the debug printk statements using macros?
Not really, they would be a pain to write as C code.
The advantage of using C code for the dummy versions of things is that we
still get type checking and we eliminate "unused variable" warnings for
parameters of the functions.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-07-31 0:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 13:13 eranian
2008-07-28 15:47 ` Stephen Rothwell
2008-07-29 6:20 ` stephane eranian
2008-07-30 23:59 ` stephane eranian
2008-07-31 0:21 ` Stephen Rothwell [this message]
2008-07-31 0:26 ` stephane eranian
2008-07-31 0:43 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731102154.b06476dd.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=eranian@gmail.com \
--cc=eranian@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®