From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Switching TestSetPageLocked to trylock_page
Date: Thu, 31 Jul 2008 17:26:51 +1000 [thread overview]
Message-ID: <200807311726.51816.nickpiggin@yahoo.com.au> (raw)
Hi,
I'm wondering if I could get a patch merged which changes all
TestSetPageLocked and replaces them with trylock_page?
It would be done so there are no functional changes.
The reason I want to (aside from having a slightly more
intuitive API), is to facilitate the implementation of lockdep
on page lock, and also to use lock semantics bitops for the
lock rather than the big-hammer barriers that come with
test_and_set_bit.
The lock bitops stuff is one of the parts of my patchset to speed
up page lock functions (which results in nearly 50% faster
pagecache throughput on my G5, and even slightly faster on x86)...
Anyway, I remember you said these kinds of changes are appropriate
for just after -rc1, and I agree it shouldn't cause much pain.
Fixing up patch conflicts is literally a matter of
s/!TestSetPageLocked/trylock_page
s/TestSetPageLocked/!trylock_page
Thoughts?
next reply other threads:[~2008-07-31 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 7:26 Nick Piggin [this message]
2008-07-31 7:38 ` KOSAKI Motohiro
2008-07-31 9:33 ` Peter Zijlstra
2008-08-05 3:14 ` Nick Piggin
2008-08-05 3:28 ` Linus Torvalds
2008-08-05 3:41 ` Nick Piggin
2008-08-05 3:57 ` Andrew Morton
2008-08-05 4:01 ` Benjamin Herrenschmidt
2008-08-05 4:18 ` Nick Piggin
2008-08-05 4:09 ` Nick Piggin
2008-08-05 4:32 ` Linus Torvalds
2008-08-05 4:44 ` Nick Piggin
2008-08-05 4:57 ` Linus Torvalds
2008-08-05 5:09 ` Nick Piggin
2008-08-05 4:25 ` Linus Torvalds
2008-08-05 4:46 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807311726.51816.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®