From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net/skfp/pmf.c: Use offsetof() macro
Date: Thu, 31 Jul 2008 23:56:14 +0100 [thread overview]
Message-ID: <20080731235614.7e9e4fa7@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <s5hsktqj8np.wl%tiwai@suse.de>
On Thu, 31 Jul 2008 18:55:06 +0200
Takashi Iwai <tiwai@suse.de> wrote:
> Self-baked macros cause bunch of compile warnings like below:
>
> CC [M] drivers/net/skfp/pmf.o
> CC net/ipv4/fib_semantics.o
> drivers/net/skfp/pmf.c:86: warning: cast from pointer to integer of different size
> drivers/net/skfp/pmf.c:87: warning: cast from pointer to integer of different size
> ...
>
> Use the standard offsetof() macro instead.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Alan Cox <alan@redhat.com>
(And this is better than the patch I sent to netdev so Ack in definite
preference to the one I posted)
prev parent reply other threads:[~2008-07-31 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 16:55 Takashi Iwai
2008-07-31 22:56 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731235614.7e9e4fa7@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®