From: Adrian Bunk <bunk@kernel.org>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: viro@zeniv.linux.org.uk, dwmw2@infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/mtd/mtdsuper.c: fix build error
Date: Sun, 3 Aug 2008 02:32:40 +0300 [thread overview]
Message-ID: <20080802233240.GA4385@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20080802225304.GD4856@orion>
On Sun, Aug 03, 2008 at 02:53:04AM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
>
> drivers/mtd/mtdsuper.c: fix build error
>
> drivers/mtd/mtdsuper.c:184: error: implicit declaration of
> function 'lookup_bdev'
> drivers/mtd/mtdsuper.c:197: error: implicit declaration of
> function 'bdput'
It already gets fs.h indirectly through linux/mtd/super.h, so while
your patch might be correct it cannot fix a compile error.
If that's with CONFIG_BLOCK=n then it's
http://bugzilla.kernel.org/show_bug.cgi?id=11225
Otherwise please send your .config .
> Introduced by commit d5686b444ff3f72808d2b3fbd58672a86cdf38e7
>
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> ---
>
> drivers/mtd/mtdsuper.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
> index 9b6af7e..ec950cd 100644
> --- a/drivers/mtd/mtdsuper.c
> +++ b/drivers/mtd/mtdsuper.c
> @@ -13,6 +13,7 @@
> #include <linux/mtd/super.h>
> #include <linux/namei.h>
> #include <linux/ctype.h>
> +#include <linux/fs.h>
>
> /*
> * compare superblocks to see if they're equivalent
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-08-02 23:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 22:53 Alexander Beregalov
2008-08-02 23:32 ` Adrian Bunk [this message]
2008-08-02 23:40 ` Alexander Beregalov
2008-08-02 23:45 ` Adrian Bunk
2008-08-02 23:52 ` Alexander Beregalov
2008-08-03 8:01 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080802233240.GA4385@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=a.beregalov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®