Re: [PATCH] JMicron JM20337 USB-SATA data corruption bugfix - device 152d:2338

[Alex Buell <alex.buell@munted.org.uk>]

On Sat, 2 Aug 2008 19:49:22 -0400 (EDT), I waved a wand and this
message magically appears in front of Alan Stern:

> > > I've done a lot of mkfs and fsck, haven't seen any problems so
> > > far. Fingers crossed that this patch works. 
> > 
> > Spoke too soon, that patch that was posted doesn't work for me.
> > Here's my log:
> 
> Which patch?  Several different ones have been posted.

This is the one that I applied:
Index: usb-2.6/drivers/usb/storage/transport.c
===================================================================
--- usb-2.6.orig/drivers/usb/storage/transport.c
+++ usb-2.6/drivers/usb/storage/transport.c
@@ -663,7 +663,7 @@ void usb_stor_invoke_transport(struct sc
 	}
 
 	/* Did we transfer less than the minimum amount required? */
-	if (srb->result == SAM_STAT_GOOD &&
+	if ((srb->result == SAM_STAT_GOOD || srb->sense_buffer[2] == 0) && scsi_bufflen(srb) - scsi_get_resid(srb) < srb->underflow)
 		srb->result = (DID_ERROR << 16) | (SUGGEST_RETRY << 24); 

> The log doesn't provide much help.  We need to see a log with 
> CONFIG_USB_STORAGE_DEBUG enabled.

Which patch should I be trying out? 

Thanks,
Alex
-- 
http://www.munted.org.uk

Fearsome grindings.