From: Oleg Nesterov <oleg@tv-sign.ru>
To: Sven Wegener <sven.wegener@stealer.net>
Cc: Oliver Pinter <pinter.oliver.villany@gmail.com>,
linux-kernel@vger.kernel.org, w@1wt.eu,
Roland McGrath <roland@redhat.com>,
john stultz <johnstul@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Oliver Pinter <oliver.pntr@gmail.com>
Subject: Re: [RFC, 2.6.26.2-rc1] posix timers: release_posix_timer: kill the bogus put_task_struct(->it_process)
Date: Sun, 3 Aug 2008 14:37:55 +0400 [thread overview]
Message-ID: <20080803103755.GA79@tv-sign.ru> (raw)
In-Reply-To: <alpine.LNX.1.10.0808030006040.2294@titan.stealer.net>
On 08/03, Sven Wegener wrote:
>
> On Sat, 2 Aug 2008, Oliver Pinter wrote:
>
> > It is an RFC for sending this patch for stable, when this patch needed, then send ACK and CC stable,
> > if not then send NAK.
>
> I'd say big NAK. Have you ever looked at the full commit message and patch
> at all? It says "release_posix_timer() can't be called with ->it_process
> != NULL.". Point. The rest is the explanation why this can't happen. And
> looking at the patch, we see that it just removes code that actually never
> gets executed under the mentioned preconditions. It's a pure cleanup patch
> and doesn't qualify for -stable. Same goes for the other posix timer patch
> you mailed out.
I agree. Perhaps the changelog was badly written...
These 2 patches are just cleanups which remove the dead code,
this is not the -stable material.
Oleg.
prev parent reply other threads:[~2008-08-03 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 21:45 Oliver Pinter
2008-08-02 21:56 ` Arjan van de Ven
2008-08-02 22:27 ` Sven Wegener
2008-08-03 10:37 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080803103755.GA79@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.pntr@gmail.com \
--cc=pinter.oliver.villany@gmail.com \
--cc=roland@redhat.com \
--cc=sven.wegener@stealer.net \
--cc=tglx@linutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®