From: Borislav Petkov <petkovbb@googlemail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: petkovbb@googlemail.com,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
alan@redhat.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] pata_legacy: export functionality to ide
Date: Sun, 3 Aug 2008 16:38:37 +0200 [thread overview]
Message-ID: <20080803143837.GA26672@gollum.tnic> (raw)
In-Reply-To: <20080803125907.67676948@lxorguk.ukuu.org.uk>
On Sun, Aug 03, 2008 at 12:59:07PM +0100, Alan Cox wrote:
> On Sun, 3 Aug 2008 09:37:56 +0200
> Borislav Petkov <petkovbb@googlemail.com> wrote:
>
> > Ok, here's a definitely better solution:
>
> Please don't stuff large important pieces of code in header files where
> they will be overlooked
What do you mean by "overlooked"? If you're looking for the function defintion,
any sensible code indexing tool will point you to the right place.
And linux/ata.h already contains several c one liners/helpers. What is the
difference between the two new functions and the ones already present there?
Although the solution i propose is not adhering to some header/c file
conventions, it is still the best one considering the other possibilities:
a) code duplication: dumb idea, bloated kernel for no reason
b) evil Kconfig SELECT pulling in core libata just so that ide might be calling
a function or two.
[.. ]
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2008-08-03 14:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 5:33 [PATCH] ide-floppy fix Borislav Petkov
2008-07-15 5:40 ` Borislav Petkov
2008-07-16 15:59 ` Bartlomiej Zolnierkiewicz
2008-07-15 20:39 ` Borislav Petkov
2008-07-15 20:58 ` Bartlomiej Zolnierkiewicz
2008-07-16 5:20 ` Borislav Petkov
2008-07-16 17:56 ` Bartlomiej Zolnierkiewicz
2008-07-20 12:06 ` Borislav Petkov
2008-07-21 19:03 ` Bartlomiej Zolnierkiewicz
2008-07-22 5:27 ` Borislav Petkov
2008-07-22 19:49 ` Bartlomiej Zolnierkiewicz
2008-07-23 6:32 ` Borislav Petkov
2008-07-23 18:51 ` Bartlomiej Zolnierkiewicz
2008-08-01 5:48 ` [PATCH] ide-generic: skip automatic probing of legacy iobases (was: Re: [PATCH] ide-floppy fix) Borislav Petkov
2008-08-02 17:02 ` Bartlomiej Zolnierkiewicz
2008-08-02 18:32 ` Borislav Petkov
2008-08-02 18:46 ` Bartlomiej Zolnierkiewicz
2008-08-03 7:37 ` [PATCH 1/2] pata_legacy: export functionality to ide Borislav Petkov
2008-08-03 11:59 ` Alan Cox
2008-08-03 13:37 ` Bartlomiej Zolnierkiewicz
2008-08-03 13:39 ` Alan Cox
2008-08-03 23:43 ` Jeff Garzik
2008-08-03 14:38 ` Borislav Petkov [this message]
2008-08-03 15:22 ` Alan Cox
2008-08-03 16:51 ` Borislav Petkov
2008-08-05 14:26 ` Sergei Shtylyov
2008-08-05 14:32 ` Boris Petkov
2008-08-05 14:41 ` Bartlomiej Zolnierkiewicz
2008-08-06 6:10 ` Borislav Petkov
2008-08-06 11:34 ` Sergei Shtylyov
2008-08-06 14:03 ` Boris Petkov
2008-08-06 15:57 ` Sergei Shtylyov
2008-08-06 19:47 ` Borislav Petkov
2008-08-06 19:46 ` Alan Cox
2008-08-06 20:04 ` Sergei Shtylyov
2008-08-07 4:36 ` [PATCH] ide-generic: handle probing of legacy io-ports v5 (was: Re: [PATCH 1/2] pata_legacy: export functionality to ide) Borislav Petkov
2008-08-07 17:06 ` Bartlomiej Zolnierkiewicz
2008-08-08 10:04 ` [PATCH] ide-generic: handle probing of legacy io-ports v5 Sergei Shtylyov
2008-08-03 7:38 ` [PATCH 2/2] ide-generic: handle probing of legacy io-ports Borislav Petkov
2008-08-03 14:11 ` Bartlomiej Zolnierkiewicz
2008-08-03 14:45 ` Borislav Petkov
2008-08-03 14:54 ` Borislav Petkov
2008-08-03 14:59 ` Bartlomiej Zolnierkiewicz
2008-08-03 15:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080803143837.GA26672@gollum.tnic \
--to=petkovbb@googlemail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®