mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Siewior <linux-crypto@ml.breakpoint.cc>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Austin Zhang <austin_zhang@linux.intel.com>,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.
Date: Mon, 4 Aug 2008 12:25:57 +0200	[thread overview]
Message-ID: <20080804102557.GA21265@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <1217844725.3454.580.camel@pmac.infradead.org>

* David Woodhouse | 2008-08-04 11:12:05 [+0100]:

>On Mon, 2008-08-04 at 05:35 -0400, Austin Zhang wrote:
>> +u32 __pure crc32c_intel_le_hw(u32 crc, unsigned char const *p, size_t
>> len)
>> +{
>> +       unsigned int iquotient = len / SCALE_F;
>> +       unsigned int iremainder = len % SCALE_F;
>> +#ifdef CONFIG_X86_64
>> +       u64 *ptmp = (u64 *)p;
>> +#else
>> +       u32 *ptmp = (u32 *)p;
>> +#endif
>
>You could perhaps just use 'unsigned long' here, to avoid the ifdef.
>
>And it would be nice if we could make libcrc32c use this too, rather
>than just the 'crypto' users.

I'm not sure if I remeber correctly but I thing Herbert was planning to
convert all users over to the crypto API to avoid compile time
dependency.

Sebastian

  reply	other threads:[~2008-08-04 10:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04  9:35 Austin Zhang
2008-08-04 10:12 ` David Woodhouse
2008-08-04 10:25   ` Sebastian Siewior [this message]
2008-08-04 10:27     ` David Woodhouse
2008-08-04 10:48     ` Herbert Xu
2008-08-04 10:35   ` Austin Zhang
2008-08-04 10:45     ` David Woodhouse
2008-08-04 10:58       ` Austin Zhang
2008-08-04 11:25         ` David Woodhouse
2008-08-04 13:45       ` Chris Mason
2008-08-04 15:42         ` Herbert Xu
2008-08-04 16:14           ` Chris Mason
2008-08-04 16:45             ` Herbert Xu
2008-08-04 17:06               ` Arjan van de Ven
2008-08-04 17:10                 ` Herbert Xu
2008-08-04 17:13                   ` Herbert Xu
2008-08-05 11:10                     ` Helge Hafting
2008-08-05 14:04                       ` Herbert Xu
2008-08-04 18:02           ` Benoit Boissinot
2008-08-05  2:08             ` Herbert Xu
2008-08-04 14:04       ` Herbert Xu
2008-08-04 14:20         ` Arjan van de Ven
2008-08-04 14:49           ` David Woodhouse
2008-08-04 14:54             ` Herbert Xu
2008-08-04 15:12           ` Herbert Xu
2008-08-04 14:13 ` David Woodhouse
2008-08-04 14:17   ` Herbert Xu
2008-08-05  9:51   ` Austin Zhang
2008-08-04 14:18 ` Herbert Xu
2008-08-04 14:19 ` Herbert Xu
2008-08-05  9:59   ` Austin Zhang
2008-08-05 10:44     ` Herbert Xu
2008-08-04 17:27 ` Randy Dunlap
2008-08-05 10:12   ` Austin Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080804102557.GA21265@Chamillionaire.breakpoint.cc \
    --to=linux-crypto@ml.breakpoint.cc \
    --cc=austin_zhang@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®