mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [3/4] MCE: Reinitialize per cpu features and ancient mces on resume
Date: Tue,  5 Aug 2008 19:17:37 +0200 (CEST)	[thread overview]
Message-ID: <20080805171737.82C561B90085@one.firstfloor.org> (raw)
In-Reply-To: <20080805717.971524000@firstfloor.org>


This fixes a long standing bug in the machine check code. On resume the
boot CPU wouldn't get its vendor specific state like thermal handling
reinitialized. This means the boot cpu wouldn't ever get any thermal
events reported again. Also the newly added ancient CPUs have the same problem.

Call the respective initialization functions on resume.


Signed-off-by: Andi Kleen <ak@linux.intel.com>

Index: linux/arch/x86/kernel/cpu/mcheck/mce_64.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_64.c
@@ -753,6 +753,8 @@ __setup("mce=", mcheck_enable);
 static int mce_resume(struct sys_device *dev)
 {
 	mce_init(NULL);
+	mce_ancient_init(&current_cpu_data);
+	mce_cpu_features(&current_cpu_data);
 	return 0;
 }
 

  parent reply	other threads:[~2008-08-05 17:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-05 17:17 [PATCH] [0/4] Updates to the x86 machine check unification Andi Kleen
2008-08-05 17:17 ` [PATCH] [1/4] MCE: Fix ifdefs for Intel thermal handler Andi Kleen
2008-08-05 17:17 ` [PATCH] [2/4] MCE: Add old machine check code to feature-removal-schedule.txt Andi Kleen
2008-08-05 17:17 ` Andi Kleen [this message]
2008-08-05 17:17 ` [PATCH] [4/4] MCE: Don't disable machine checks during code patching Andi Kleen
2008-08-08 22:23 ` [PATCH] [0/4] Updates to the x86 machine check unification H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080805171737.82C561B90085@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®