mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ira Snyder <iws@ovro.caltech.edu>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Simple UART driver help and TTY questions
Date: Wed, 6 Aug 2008 14:46:35 -0700	[thread overview]
Message-ID: <20080806214635.GM6257@ovro.caltech.edu> (raw)
In-Reply-To: <489A1364.4020809@gmail.com>

On Wed, Aug 06, 2008 at 11:11:00PM +0200, Jiri Slaby wrote:
> conOn 08/05/2008 06:33 PM, Ira Snyder wrote:
>> static void tiny_config_port(struct uart_port *port, int flags)
>> {
>> 	FUNC_ENTER();
>
>         if (flags & UART_CONFIG_TYPE)
>                 port->type = PORT_16550A;
>
>> }
>
> According to the straces, you get -EIO from ioctl and read which most 
> likely means TTY_IO_ERROR bit set due to tiny_port->type = PORT_UNKNOWN 
> (i.e. 0). Try the above.

Not quite, but it got me on the right track. I needed to set port->type
before calling uart_add_one_port().

Now it gets into my code. Previously, it had never even called any of my
code. None of it. Unfortunately, I ran it and it segfaulted. Turns out
that Greg's tinyserial driver didn't implement ops->set_termios() and
that was the cause. Implementing that got everything working.

Now I get in my dmesg:
[   73.813893] ttytiny: Tiny serial driver
[   83.714486] Enter: tiny_startup
[   83.717676] Enter: tiny_set_termios
[   83.721193] Enter: tiny_set_mctrl
[   85.463793] Enter: tiny_stop_rx
[   85.466987] Enter: tiny_set_mctrl
[   85.470328] Enter: tiny_shutdown

And that looks very reasonable. (It was produced by cat /dev/ttytiny0,
for your information).

Thanks a lot for your help! That problem had me completely stumped for a
couple of days now :)

Ira

  reply	other threads:[~2008-08-06 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-05 16:33 Ira Snyder
2008-08-05 21:21 ` Jiri Slaby
2008-08-06 19:32   ` Ira Snyder
2008-08-06 21:11 ` Jiri Slaby
2008-08-06 21:46   ` Ira Snyder [this message]
2008-08-06 21:51     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080806214635.GM6257@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®