From: Simon Horman <horms@verge.net.au>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Sven Wegener <sven.wegener@stealer.net>,
Michael Ellerman <michael@ellerman.id.au>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus()
Date: Thu, 7 Aug 2008 09:25:24 +1000 [thread overview]
Message-ID: <20080806232523.GF10636@verge.net.au> (raw)
In-Reply-To: <20080806131900.GI2055@parisc-linux.org>
On Wed, Aug 06, 2008 at 07:19:01AM -0600, Matthew Wilcox wrote:
> On Wed, Aug 06, 2008 at 10:57:21AM +1000, Simon Horman wrote:
> > Check the return value of device_create_bin_file in pci_create_bus and
> > unwind if necessary. Don't propagate error to caller, as failure to create
> > these files shouldn't prevent PCI from being initialised.
>
> Much better ... one nit though:
>
> > static void pci_create_legacy_files(struct pci_bus *b)
> > {
> [...]
> > +
> > + return 0;
>
> I'm sure the compiler warns about that.
Amusingly, yes.
--
Horms -> looks for somewhere to hide
next prev parent reply other threads:[~2008-08-07 0:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 10:16 Simon Horman
2008-08-05 10:33 ` Michael Ellerman
2008-08-05 10:39 ` Sven Wegener
2008-08-05 11:00 ` Simon Horman
2008-08-05 11:14 ` Simon Horman
2008-08-05 11:28 ` Matthew Wilcox
2008-08-05 12:15 ` Simon Horman
2008-08-05 12:26 ` Matthew Wilcox
2008-08-06 0:57 ` Simon Horman
2008-08-06 13:19 ` Matthew Wilcox
2008-08-06 23:25 ` Simon Horman [this message]
2008-08-06 23:30 ` Simon Horman
2008-08-07 0:30 ` Michael Ellerman
2008-08-07 1:06 ` Simon Horman
2008-08-07 4:56 ` Simon Horman
2008-08-07 16:50 ` Jesse Barnes
2008-08-07 22:59 ` Simon Horman
2008-08-05 13:21 ` Sven Wegener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806232523.GF10636@verge.net.au \
--to=horms@verge.net.au \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michael@ellerman.id.au \
--cc=sven.wegener@stealer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®