mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Michael Davidson <md@google.com>
Cc: mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: prevent binaries from making system calls using the wrong syscall interface
Date: Thu, 7 Aug 2008 09:49:20 +0200	[thread overview]
Message-ID: <20080807074920.GC16610@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20080807003459.37CC629624@localhost>

> Prevent binaries from making system calls using other than one
> of the "normal" system call interfaces for that binary type.
> 
> Currently there is nothing to prevent 64 bit binaries from
> attempting to make system calls using the 32 bit system call
> interfaces and vice versa.

I thought this was a feature?

> Index: linux-2.6.26.2/arch/x86/ia32/ia32entry.S
> ===================================================================
> --- linux-2.6.26.2.orig/arch/x86/ia32/ia32entry.S	2008-08-06 09:19:01.000000000 -0700
> +++ linux-2.6.26.2/arch/x86/ia32/ia32entry.S	2008-08-06 13:34:54.566992000 -0700
> @@ -123,6 +123,8 @@
>   	.quad 1b,ia32_badarg
>   	.previous	
>  	GET_THREAD_INFO(%r10)
> +	testl  $_TIF_IA32,threadinfo_flags(%r10)
> +	jz     ia32_bad_abi
>  	orl    $TS_COMPAT,threadinfo_status(%r10)
>  	testl  $(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT|_TIF_SECCOMP),threadinfo_flags(%r10)
>  	CFI_REMEMBER_STATE

...and slowing down all syscalls for this is certainly bad idea.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-08-07  7:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07  0:34 Michael Davidson
2008-08-07  7:49 ` Pavel Machek [this message]
2008-08-07  7:50 ` Mikael Pettersson
2008-08-07 10:15 ` Alan Cox
2008-08-07 14:14 ` Arjan van de Ven
2008-08-08  6:29 ` Jeremy Fitzhardinge
2008-08-08 11:16 ` Andi Kleen
2008-08-08 16:09   ` Michael Davidson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080807074920.GC16610@atrey.karlin.mff.cuni.cz \
    --to=pavel@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=md@google.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®