From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: airlied@linux.ie, akpm <akpm@linux-foundation.org>
Subject: [PATCH -next] drm: sis depends on FB_SIS
Date: Thu, 7 Aug 2008 08:32:28 -0700 [thread overview]
Message-ID: <20080807083228.0fc40405.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
cc: airlied@linux.ie
drm/sis calls mm functions in fb/sis, so make the former depend
on the latter.
This one happened with FB_SIS=m, AGP_SIS=y, DRM_SYS=y.
sis1.out:sis_mm.c:(.text+0x70014): undefined reference to `sis_free'
sis1.out:sis_mm.c:(.text+0x7002a): undefined reference to `sis_malloc'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20080806.orig/drivers/gpu/drm/Kconfig
+++ linux-next-20080806/drivers/gpu/drm/Kconfig
@@ -86,7 +86,7 @@ config DRM_MGA
config DRM_SIS
tristate "SiS video cards"
- depends on DRM && AGP
+ depends on DRM && AGP && FB_SIS
help
Choose this option if you have a SiS 630 or compatible video
chipset. If M is selected the module will be called sis. AGP
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
next reply other threads:[~2008-08-07 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 15:32 Randy Dunlap [this message]
2008-08-07 23:09 ` Dave Airlie
2008-08-08 0:55 ` Randy Dunlap
2008-08-08 2:11 ` Dave Airlie
2008-08-12 12:59 ` Adrian Bunk
2008-08-12 21:37 ` Dave Airlie
2008-08-13 21:57 ` [RFC: -next patch] don't allow FB_SIS=m, DRM_SIS=y Adrian Bunk
2008-08-19 22:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807083228.0fc40405.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome