mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Michael S. Tsirkin" <m.s.tsirkin@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org, matthew@wil.cx
Subject: Re: T60p not coming out of suspend to RAM since 2.6.27-rc1
Date: Thu, 7 Aug 2008 17:27:12 -0700	[thread overview]
Message-ID: <200808071727.13317.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080807232819.GA7984@google.com>

On Thursday, August 7, 2008 4:28 pm Michael S. Tsirkin wrote:
> In both 2.6.27-rc1 and 2.6.27-rc2, my laptop won't come out of
> suspend to ram: it blinks the crescent one or twice,
> and hangs. It does resume fine under 2.6.26.
>
> I bisected the problem and got the following commit:
>
> commit ce6fce4295ba727b36fdc73040e444bd1aae64cd
> Author: Matthew Wilcox <matthew@wil.cx>
> Date:   Fri Jul 25 15:42:58 2008 -0600
>
>     PCI MSI: Don't disable MSIs if the mask bit isn't supported
>
>     David Vrabel has a device which generates an interrupt storm on the
> INTx pin if we disable MSI interrupts altogether.  Masking interrupts is
> only a performance optimisation, so we can ignore the request to mask the
> interrupt.
>
>     Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
>     Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Reverting ce6fce4295ba727b36fdc73040e444bd1aae64cd
> fixes resume from suspend to RAM for me.
>
> Steps to reproduce:
>
> Press Fn-F4 to suspend, press Fn to resume.
> This works on 2.6.26, hangs on vanilla 2.6.27-rc1
> and 2.6.27-rc2, works on 2.6.27-rc2 with reverted ce6fce..
>
> Bug added to bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=11283

I noted in the bug that I think this is a duplicate.  Can you try pulling my
for-linus branch into your tree to see if it fixes things for you?

git pull git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6.git for-linus

from inside your kernel tree should do it.

Thanks,
Jesse

      reply	other threads:[~2008-08-08  0:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 23:28 Michael S. Tsirkin
2008-08-08  0:27 ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808071727.13317.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=m.s.tsirkin@gmail.com \
    --cc=matthew@wil.cx \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®