From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753949AbYHGMWe (ORCPT ); Thu, 7 Aug 2008 08:22:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752859AbYHGMWC (ORCPT ); Thu, 7 Aug 2008 08:22:02 -0400 Received: from fgwmail8.fujitsu.co.jp ([192.51.44.38]:34498 "EHLO fgwmail8.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbYHGMV6 (ORCPT ); Thu, 7 Aug 2008 08:21:58 -0400 Date: Thu, 07 Aug 2008 20:00:37 +0900 From: KOSAKI Motohiro To: Lee Schermerhorn Subject: Re: Race condition between putback_lru_page and mem_cgroup_move_list Cc: kosaki.motohiro@jp.fujitsu.com, balbir@linux.vnet.ibm.com, MinChan Kim , KAMEZAWA Hiroyuki , linux-mm , Rik van Riel , LKML In-Reply-To: <1218041585.6173.45.camel@lts-notebook> References: <489741F8.2080104@linux.vnet.ibm.com> <1218041585.6173.45.camel@lts-notebook> Message-Id: <20080807185203.A8C2.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > If you mean the "active/inactive list transition" in > shrink_[in]active_list(), these are already batched under zone lru_lock > with batch size determined by the 'release pages' pvec. So, I think > we're OK here. No. AFAIK shrink_inactive_list batched zone->lru_lock, but it doesn't batched mz->lru_lock. then, spin_lock_irqsave is freqently called.