From: Pavel Machek <pavel@suse.cz>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
krzysztof.h1@poczta.fm, adaplas@pol.net,
akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: 2.6.27-rc1: softcursor behaviour changed
Date: Fri, 8 Aug 2008 00:07:55 +0200 [thread overview]
Message-ID: <20080807220755.GA11460@elf.ucw.cz> (raw)
In-Reply-To: <489AD9C1.8020405@eu.citrix.com>
On Thu 2008-08-07 12:17:21, Stefano Stabellini wrote:
> Pavel Machek wrote:
>
> > Hi!
> >
> >> In 2.6.26, this
> >>
> >> echo -e "\33[10;5000]\33[11;50]\33[?18;0;136c\33[?102m"
> >>
> >> produces some variation on cursor. on 2.6.27-rc1, I have no cursor at
> >> all :-(.
> >
> > The patch that changed it is below... and I must say I liked the old
> > behaviour better. Unlike blinking, high-brightness background is
> > actually useful. Can we get that one reverted?
>
>
> The problem is not a matter of taste but a matter of correctness: the
> build_attr function in drivers/char/vt.c stores the blink attribute as
> the forth bit of the background color.
> Then in fbcon we are interpreting the same forth bit of the background
> color as intensity bit.
...which works pretty well. We can't reasonably blink in fbcon, so we
highlight it with bright background, instead. Even old VGA had option
to do that.
> My patch fixes that.
AFAICS high bit is now completely ignored now. That makes it
useless...
For example I can no longer see my cursor.
So, if 2.6.26 behaviour is "incorrect", can you show example where it
matters, and how your patch "helps"?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-08-07 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 21:20 Pavel Machek
2008-08-07 8:57 ` Pavel Machek
2008-08-07 11:17 ` Stefano Stabellini
2008-08-07 22:07 ` Pavel Machek [this message]
2008-08-08 9:49 ` Stefano Stabellini
2008-08-08 18:17 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807220755.GA11460@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=adaplas@pol.net \
--cc=akpm@linux-foundation.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®