From: Andrew Morton <akpm@linux-foundation.org>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
rene.herman@keyaccess.nl, rene.herman@gmail.com
Subject: Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree
Date: Fri, 8 Aug 2008 14:28:47 -0700 [thread overview]
Message-ID: <20080808142847.9e4f33b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <86802c440808081413u2249fff1g1940ff472cdf10e7@mail.gmail.com>
On Fri, 8 Aug 2008 14:13:29 -0700
"Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
> > commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped
> > debugging printks in arch/x86/kernel/mppparse.c into regular ones. The
> > one at the top of smp_scan_config() in particular also prints on
> > !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything
> > resembling MP tables which makes their lowly UP owners wonder...
> >
> > Given that it was up to this point also not considered valuable user-level
> > information, let's just kill that one.
> >
>
> why? that just three lines debug debug info.
For the reasons described in the changelog text. They look quite valid
to me.
next prev parent reply other threads:[~2008-08-08 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200808082051.m78KpZGC027833@imap1.linux-foundation.org>
2008-08-08 21:13 ` Yinghai Lu
2008-08-08 21:28 ` Andrew Morton [this message]
2008-08-08 21:44 ` Yinghai Lu
2008-08-09 5:15 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080808142847.9e4f33b2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rene.herman@gmail.com \
--cc=rene.herman@keyaccess.nl \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome