From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Adrian Bunk <bunk@kernel.org>
Cc: Alan Cox <alan@redhat.com>, Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] fix watchdog/wdt285.c compilation
Date: Sat, 9 Aug 2008 11:05:27 +0100 [thread overview]
Message-ID: <20080809100526.GB18510@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080808160346.GE14495@cs181140183.pp.htv.fi>
On Fri, Aug 08, 2008 at 07:03:46PM +0300, Adrian Bunk wrote:
> wdt285.c:211: error: 'KERN_WARN' undeclared (first use in this function)
It might be worth having the kernel provide an alias for KERN_WARN
to avoid these kinds of errors in the future. Many people have
said that they make this mistake as well, I certainly have many a
time.
The problem is that we have things like KERN_ERR, KERN_CRIT rather
than KERN_ERROR and KERN_CRITICAL, but so we think "oh, we're using
shortened versions" but then you come to KERN_WARNING rather than
KERN_WARN.
However, since xxx_WARNING is a recognised name for the severity
level (see syslog(3)) we shouldn't get rid of that.
Needless to say, this fix for wdt285 still needs to get to Linus ASAP.
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
prev parent reply other threads:[~2008-08-09 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 16:03 Adrian Bunk
2008-08-09 10:05 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809100526.GB18510@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®