From: Christoph Hellwig <hch@infradead.org>
To: Ian Kent <raven@themaw.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
autofs mailing list <autofs@linux.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage
Date: Sat, 9 Aug 2008 08:47:39 -0400 [thread overview]
Message-ID: <20080809124739.GA16308@infradead.org> (raw)
In-Reply-To: <20080807114002.4142.30417.stgit@web.messagingengine.com>
On Thu, Aug 07, 2008 at 07:40:06PM +0800, Ian Kent wrote:
> Usage of the AUTOFS_TYPE_* defines is a little confusing and
> appears inconsistent.
Not enough of an explanation for this patch.
It does:
- move AUTOFS_TYPE_INDIRECT/AUTOFS_TYPE_DIRECT/AUTOFS_TYPE_OFFSET
to include/linux/auto_fs4.h. Obviously okay but should mentioned
in the changelog.
- add a new, unused AUTOFS_TYPE_ANY constant. Why?
- add a new AUTOFS_TYPE_TRIGGER and use it instead of
AUTOFS_TYPE_DIRECT or in one single case
(AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET). Definitively needs a good
explanation.
- replaces one use of sbi->type = 0 with AUTOFS_TYPE_INDIRECT (0x0001).
Why?
next prev parent reply other threads:[~2008-08-09 12:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 11:40 Ian Kent
2008-08-07 11:40 ` [PATCH 2/4] autofs4 - track uid and gid of last mount requester Ian Kent
2008-08-07 20:46 ` Andrew Morton
2008-08-07 22:12 ` Serge E. Hallyn
2008-08-08 3:48 ` Ian Kent
2008-08-08 4:44 ` Ian Kent
2008-08-08 14:58 ` Serge E. Hallyn
2008-08-09 6:05 ` Ian Kent
2008-08-09 13:31 ` Serge E. Hallyn
2008-08-25 18:05 ` Serge E. Hallyn
2008-08-07 22:15 ` Serge E. Hallyn
2008-08-08 3:13 ` Ian Kent
2008-08-08 15:23 ` Serge E. Hallyn
2008-08-08 3:25 ` Ian Kent
2008-08-08 5:37 ` Ian Kent
2008-08-07 11:40 ` [PATCH 3/4] autofs4 - devicer node ioctl docoumentation Ian Kent
2008-08-09 13:00 ` Christoph Hellwig
2008-08-07 11:40 ` [PATCH 4/4] autofs4 - add miscelaneous device for ioctls Ian Kent
2008-08-07 21:10 ` Andrew Morton
2008-08-08 3:39 ` Ian Kent
2008-08-08 5:31 ` Andrew Morton
2008-08-08 6:12 ` Ian Kent
2008-08-08 6:33 ` Andrew Morton
2008-08-09 12:59 ` Christoph Hellwig
2008-08-09 15:29 ` Ian Kent
2008-08-09 17:18 ` Christoph Hellwig
2008-08-10 5:20 ` Ian Kent
2008-08-09 12:47 ` Christoph Hellwig [this message]
2008-08-09 15:17 ` [PATCH 1/4] autofs4 - cleanup autofs mount type usage Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809124739.GA16308@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=autofs@linux.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®