From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
video4linux-list@redhat.com,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] V4L1: make PMS not auto-grab port 0x250
Date: Sat, 9 Aug 2008 21:46:57 +0100 [thread overview]
Message-ID: <20080809214657.3b5318d1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <489DE890.1090103@keyaccess.nl>
I have a PMS card. It was the hot technology of 199x about the same time
as doom came out. I'm probably the only person who still has one ;)
I'm going to NAK this however because passing in a port is a really dumb
interface. The PMS card can only be at port 0x250 so if you load it there
is no doubt and confusion involved.
The code is fine, the behaviour is correct. Ingo should fix his config
stuff.
Just apply a tiny bit of rational thought here. There is exactly ONE
Ingo. He's a smart cookie and can add exception lists to his tester.
There are millions of users some of whom are brilliant, others are not
computer wizards. The code should be optimised for them not for Ingo -
Ingo is an optimisation for the special case not the normal workload!
Alan
next prev parent reply other threads:[~2008-08-09 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-09 18:57 Rene Herman
2008-08-09 20:46 ` Alan Cox [this message]
2008-08-09 22:01 ` Rene Herman
2008-08-09 21:55 ` Alan Cox
2008-08-09 22:17 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809214657.3b5318d1@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rene.herman@keyaccess.nl \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®