From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Grant Coady <gcoady.lk@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Query: should 'Marvell SATA support' depend on PCI?
Date: Sun, 10 Aug 2008 14:26:39 +0200 [thread overview]
Message-ID: <200808101426.39778.rjw@sisk.pl> (raw)
In-Reply-To: <20080810125432.3504a7fa@lxorguk.ukuu.org.uk>
On Sunday, 10 of August 2008, Alan Cox wrote:
> > > doesn't have 'depends on PCI && EXPERIMENTAL' like other drivers around
> > > it, this is okay or should it also depend on PCI?
> >
> > Well, I think so. It obviously depends on PCI.
>
> Obviously ? Try looking a bit harder
>
> /**
> * mv_platform_probe - handle a positive probe of an soc Marvell
> * host
> * @pdev: platform device found
> *
> * LOCKING:
> * Inherited from caller.
> */
> static int mv_platform_probe(struct platform_device *pdev)
Sorry, I didn't notice the '#ifdef CONFIG_PCI' in there.
Rafael
next prev parent reply other threads:[~2008-08-10 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-10 6:47 Grant Coady
2008-08-10 12:08 ` Rafael J. Wysocki
2008-08-10 11:54 ` Alan Cox
2008-08-10 12:26 ` Rafael J. Wysocki [this message]
2008-08-10 12:24 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808101426.39778.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gcoady.lk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®