From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: apic interrupts - move assignments to irqinit_32.c
Date: Mon, 11 Aug 2008 15:06:47 +0200 [thread overview]
Message-ID: <20080811130647.GA23289@elte.hu> (raw)
In-Reply-To: <20080811125729.GB2842@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
>
> > 64bit mode APIC interrupt handlers are set within irqinit_64.c.
> > Lets do tha same for 32bit mode which would help in furter code merging.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> >
> > I found it useful for APIC code merging process (in which
> > i'm now). So please review and test if possible.
> > Any comments are quite welcome!
> >
> > Ugh... almost forget - the patch is over -tip tree
> > commit 62c67a7cc7dbd9c8d92d49cfd7d5ca1d8f354616
>
> applied to tip/x86/core for more testing, thanks Cyrill.
doesnt build:
arch/x86/mach-default/setup.c:44: warning: ‘irq2’ defined but not used
arch/x86/kernel/irqinit_32.c: In function ‘native_init_IRQ’:
arch/x86/kernel/irqinit_32.c:139: error: ‘irq2’ undeclared (first use in this function)
arch/x86/kernel/irqinit_32.c:139: error: (Each undeclared identifier is reported only once
arch/x86/kernel/irqinit_32.c:139: error: for each function it appears in.)
with:
http://redhat.com/~mingo/misc/config-Mon_Aug_11_14_48_29_CEST_2008.bad
Ingo
next prev parent reply other threads:[~2008-08-11 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 19:50 Cyrill Gorcunov
2008-08-11 12:57 ` Ingo Molnar
2008-08-11 13:06 ` Ingo Molnar [this message]
2008-08-11 14:34 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811130647.GA23289@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®