From: Ingo Oeser <ioe-lkml@rameria.de>
To: David Howells <dhowells@redhat.com>
Cc: sfr@canb.auug.org.au, jmorris@namei.org, hch@infradead.org,
davem@davemloft.net, sfrench@us.ibm.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/2] CRED: Introduce credential access wrappers
Date: Tue, 12 Aug 2008 21:02:14 +0200 [thread overview]
Message-ID: <200808122102.15794.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20080812132850.5472.5131.stgit@warthog.procyon.org.uk>
Hi David,
On Tuesday 12 August 2008, David Howells wrote:
> Wrappers are introduced into a new header (linux/cred.h) for UID/GID,
> EUID/EGID, SUID/SGID, FSUID/FSGID, cap_effective and current's subscribed
> user_struct.
Why macros? When introducing APIs using trivial inlines makes sure that
the conversion is correct, type correct and side effect free for the callers.
Macros cannot ensure this without pain.
Please respin this patch with inlines. If that needs header changes,
your CRED subsytem might need that, too.
Best Regards
Ingo Oeser
next prev parent reply other threads:[~2008-08-12 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 13:28 [PATCH 0/2] Introduce credentials API David Howells
2008-08-12 13:28 ` [PATCH 1/2] CRED: Alter XFS so as to avoid namespace collisions with upcoming COW creds David Howells
2008-08-12 22:55 ` James Morris
2008-08-12 23:01 ` Christoph Hellwig
2008-08-12 13:28 ` [PATCH 2/2] CRED: Introduce credential access wrappers David Howells
2008-08-12 19:02 ` Ingo Oeser [this message]
2008-08-12 20:27 ` David Howells
2008-08-12 22:59 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808122102.15794.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®