From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbYHLXVe (ORCPT ); Tue, 12 Aug 2008 19:21:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752128AbYHLXVZ (ORCPT ); Tue, 12 Aug 2008 19:21:25 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:56098 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457AbYHLXVY (ORCPT ); Tue, 12 Aug 2008 19:21:24 -0400 Date: Wed, 13 Aug 2008 09:21:22 +1000 From: Simon Horman To: "Luck, Tony" Cc: "linux-ia64@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [patch] IA64: make rsvd_region and num_rsvd_regions static Message-ID: <20080812232121.GC11363@verge.net.au> References: <20080805095739.GA12078@verge.net.au> <57C9024A16AD2D4C97DC78E552063EA30844AEFB@orsmsx505.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA30844AEFB@orsmsx505.amr.corp.intel.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 12, 2008 at 01:47:37PM -0700, Luck, Tony wrote: > > rsvd_region and num_rsvd_regions are only accessed in > > arch/ia64/kernel/setup.c, so they should be static. > > Are you looking at -mm or linux-next? In my tree I see: Whatever I was looking at, I was wrong. Sorry for the noise. > arch/ia64/mm/contig.c: for (i = 0; i < num_rsvd_regions; i++) { > arch/ia64/mm/contig.c: range_end = min(end, rsvd_region[i].start & PAGE_MASK); > arch/ia64/mm/contig.c: free_start = PAGE_ALIGN(rsvd_region[i].end);