Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60 (bisected)

[Pavel Machek <pavel@suse.cz>]

On Tue 2008-08-12 17:48:27, Milan Broz wrote:
> 
> >>>> yes. maybe some userspace tool controlling frequency is involved, no idea yet.
> >>>> But it is 2.6.26 tree for sure.
> >>>>         
> >>> So it definitely is in 2.6.26.2, and it definitely is in 2.6.26?
> >>>       
> >
> >
> > The bug is _not_ in 2.6.26, it was introduced in 2.6.26.1.
> >
> > The problem is, that now the CPU frequency doesn't decrease at some
> > temperature level and fan is unable to cool it properly.
> >
> > bisect on 2.6.26.y tree finished in this patch:
> > (I expect similar patch in 2.6.27-rc)
> >
> > commit 04f496871e8af87a1e40c504371a206fd7389193
> > Author: Thomas Renninger <trenn@suse.de>
> > Date:   Wed Jul 30 18:20:10 2008 +0000
> >
> >   
> and this seems to fix it for me:
> --
> 
> Do not use unsigned int if there is test for negative number...
> 
> See drivers/acpi/processor_perflib.c
>   static unsigned int ignore_ppc = -1;
> ...
>   if (event == CPUFREQ_START && ignore_ppc <= 0) {
>        ignore_ppc = 0;
> ...
> 
> Signed-off-by: Milan Broz <mbroz@redhat.com>

Tested-by: Pavel Machek <pavel@suse.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html