mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "John Kacur" <jkacur@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Andy Whitcroft" <apw@shadowen.org>,
	rdunlap@xenotime.net, jschopp@austin.ibm.com
Subject: Re: drop overzealous ERROR: do not initialise statics to 0 or NULL from checkpatch.pl
Date: Wed, 13 Aug 2008 14:15:36 +0200	[thread overview]
Message-ID: <200808131415.36851.arnd@arndb.de> (raw)
In-Reply-To: <520f0cf10808130339r5dd22e12w3477d6bddd545db1@mail.gmail.com>

On Wednesday 13 August 2008, John Kacur wrote:
> Could we drop this somewhat overzealous "ERROR: do not initialise
> statics to 0 or NULL" from checkpatch.pl?

I totally agree we should drop it.

> Reasoning:
> 1. This is not part of Documentation/CodingStyle

However, it is in http://kernel-janitor.sourceforge.net/TODO and should
be dropped from there as well.

> 3. It can be a good form of documentation.

I don't think so. Every C programmer should know that it is the
same. 

> 5. It doesn't even change the object size (thus kernel size) to do so.
> Demo with user space code.

I'm not sure what the last compiler version was on which it made the
difference, probably 2.95 or 3.0 or something else that is no longer
supported.
I do remember that at some point in time, we could save a few bytes by
doing it.

	Arnd <><

  parent reply	other threads:[~2008-08-13 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 10:39 John Kacur
2008-08-13 11:50 ` John Kacur
2008-08-13 12:15 ` Arnd Bergmann [this message]
2008-08-13 20:19   ` Guennadi Liakhovetski
2008-08-14  8:42     ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808131415.36851.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=apw@shadowen.org \
    --cc=jkacur@gmail.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®