From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix the race between walk_tg_tree and sched_create_group
Date: Thu, 14 Aug 2008 10:46:06 +0200 [thread overview]
Message-ID: <20080814084606.GB1650@elte.hu> (raw)
In-Reply-To: <1218702968.10800.199.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Wed, 2030-08-14 at 15:56 +0800, Zhang, Yanmin wrote:
> > With 2.6.27-rc3, I hit a kernel panic when running volanoMark on my
> > new x86_64 machine. I also hit it with other 2.6.27-rc kernels.
> > See below log.
> >
> > Basically, function walk_tg_tree and sched_create_group have a race between
> > accessing and initiating tg->children. Below patch fixes it by moving
> > tg->children initiation to the front of linking tg->siblings to parent->children.
> >
> > Signed-off-by: Zhang Yanmin <yanmin_zhang@linux.intel.com>
>
> Nice catch
>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
applied to tip/sched/urgent - thanks.
Ingo
prev parent reply other threads:[~2008-08-14 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2030-08-14 7:56 Zhang, Yanmin
2008-08-14 8:36 ` Peter Zijlstra
2008-08-14 8:46 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814084606.GB1650@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®