From: Ingo Molnar <mingo@elte.hu>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: linux-kernel@vger.kernel.org, Max Krasnyansky <maxk@qualcomm.org>,
lizf@cn.fujitsu.com, jeff.chua.linux@gmail.com,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Resurect proper handling of maxcpus= kernel option (take 2)
Date: Thu, 14 Aug 2008 11:11:20 +0200 [thread overview]
Message-ID: <20080814091120.GA18771@elte.hu> (raw)
In-Reply-To: <1218491731-10673-1-git-send-email-maxk@qualcomm.com>
* Max Krasnyansky <maxk@qualcomm.com> wrote:
> From: Max Krasnyansky <maxk@qualcomm.org>
>
> For some reason we had two parsers registered for maxcpus=. One in init/main.c
> and another in arch/x86/smpboot.c. So I nuked the one in arch/x86.
>
> Also 64-bit kernels used to handle maxcpus= as documented in
> Documentation/cpu-hotplug.txt. CPUs with 'id > maxcpus' are initialized
> but not booted. 32-bit version for some reason ignored them even though
> all the infrastructure for booting them later is there.
>
> In the current mainline both 64 and 32 bit versions are broken.
> This patch restores the correct behaviour. I've tested x86_64 version on
> 4- and 8- way Core2 and 2-way Opteron based machines. Various config
> combinations SMP, !SMP, CPU_HOTPLUG, !CPU_HOTPLUG.
> Booted with maxcpus=1 and maxcpus=4, etc. Everything is working as expected.
>
> So far we've received two reports from different people confirming that 32-bit
> version also works fine, both on dual core laptops and 16way server machines.
>
> This version fixes visws breakage pointed out by Ingo.
applied to tip/x86/urgent, thanks Max.
Ingo
prev parent reply other threads:[~2008-08-14 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 21:55 Max Krasnyansky
2008-08-14 9:11 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814091120.GA18771@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=maxk@qualcomm.com \
--cc=maxk@qualcomm.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®