mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: sfr@canb.auug.org.au, mchan@broadcom.com, netdev@vger.kernel.org,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: Tree for August 15 (bnx2) [resend/lost]
Date: Fri, 15 Aug 2008 15:17:15 -0700 (PDT)	[thread overview]
Message-ID: <20080815.151715.111675039.davem@davemloft.net> (raw)
In-Reply-To: <20080815084116.340ac526.randy.dunlap@oracle.com>

From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Fri, 15 Aug 2008 08:41:16 -0700

> When VLAN is not enabled, bnx2 build fails with:
> 
> drivers/net/bnx2.c: In function 'bnx2_rx_int':
> drivers/net/bnx2.c:2959: error: dereferencing pointer to incomplete type
> drivers/net/bnx2.c:2960: error: dereferencing pointer to incomplete type
> make[2]: *** [drivers/net/bnx2.o] Error 1

Does this fix it for you?

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index d454810..2486a65 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -35,8 +35,8 @@
 #include <linux/time.h>
 #include <linux/ethtool.h>
 #include <linux/mii.h>
-#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
 #include <linux/if_vlan.h>
+#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
 #define BCM_VLAN 1
 #endif
 #include <net/ip.h>

  reply	other threads:[~2008-08-15 22:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15  8:40 linux-next: Tree for August 15 Stephen Rothwell
2008-08-15 15:41 ` linux-next: Tree for August 15 (bnx2) [resend/lost] Randy Dunlap
2008-08-15 22:17   ` David Miller [this message]
2008-08-15 23:41     ` Randy Dunlap
     [not found] ` <s5hr68q5rm8.wl%tiwai@suse.de>
2008-08-15 19:02   ` [PATCH] Fix allocation sizes of knfsd raparm hash J. Bruce Fields
2008-08-16  8:45     ` Takashi Iwai
2008-08-18 14:59       ` J. Bruce Fields
2008-08-18  5:49 ` linux-next: Tree for August 15 Tino Keitel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080815.151715.111675039.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®