From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbYHOIWb (ORCPT ); Fri, 15 Aug 2008 04:22:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756771AbYHOIWO (ORCPT ); Fri, 15 Aug 2008 04:22:14 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:57382 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756442AbYHOIWL (ORCPT ); Fri, 15 Aug 2008 04:22:11 -0400 Date: Fri, 15 Aug 2008 10:21:47 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Thomas Gleixner , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] x86: make 32bit support per_cpu vector fix #1 Message-ID: <20080815082147.GB4776@elte.hu> References: <1218766832-20476-1-git-send-email-yhlu.kernel@gmail.com> <1218766832-20476-2-git-send-email-yhlu.kernel@gmail.com> <1218766832-20476-3-git-send-email-yhlu.kernel@gmail.com> <1218766832-20476-4-git-send-email-yhlu.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1218766832-20476-4-git-send-email-yhlu.kernel@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > +#ifdef CONFIG_SMP > + return cpu_online_map; > +#else > + return cpumask_of_cpu(0); > +#endif unrelated sidenote - shouldnt the scheduler define cpu_online_map to cpumask_of_cpu(0) on UP, to avoid such ugly #ifdefs? Ingo