From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752930AbYHQRRm (ORCPT ); Sun, 17 Aug 2008 13:17:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753420AbYHQRRX (ORCPT ); Sun, 17 Aug 2008 13:17:23 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:31116 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbYHQRRW (ORCPT ); Sun, 17 Aug 2008 13:17:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=wMKq7h31UPfxQC2q3sop/o/K8Y4BFyktDSv6cIGvhXTHB0Jxi5rvVjVNulFhRaiyhk uRgqHok8vU515WyiBdSDq+iMkgx/WB7ANZ2e7j9X3vf2Wc9KCEMdDbUOrVyldgTa3RI3 ZjDmr6nOwYte2NJAORWgiSl7xEzIV+ddNzlX0= From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Sun, 17 Aug 2008 19:15:01 +0200 Message-Id: <20080817171501.27943.57473.sendpatchset@localhost.localdomain> In-Reply-To: <20080817171454.27943.37234.sendpatchset@localhost.localdomain> References: <20080817171454.27943.37234.sendpatchset@localhost.localdomain> Subject: [PATCH 2/9] ide-disk: set_addressing() fixes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Return -EIO if arg > 0 and LBA48 is unsupported. * No need to reset ->addressing. * Make ->addressing a single bit flag. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ide/ide-disk.c | 11 +++++------ include/linux/ide.h | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) Index: b/drivers/ide/ide-disk.c =================================================================== --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c @@ -694,14 +694,13 @@ static int set_addressing(ide_drive_t *d if (arg < 0 || arg > 2) return -EINVAL; - drive->addressing = 0; - - if (drive->hwif->host_flags & IDE_HFLAG_NO_LBA48) - return 0; - - if (ata_id_lba48_enabled(drive->id) == 0) + if (arg && ((drive->hwif->host_flags & IDE_HFLAG_NO_LBA48) || + ata_id_lba48_enabled(drive->id) == 0)) return -EIO; + if (arg == 2) + arg = 0; + drive->addressing = arg; return 0; Index: b/include/linux/ide.h =================================================================== --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -507,7 +507,7 @@ struct ide_drive_s { unsigned sleeping : 1; /* 1=sleeping & sleep field valid */ unsigned post_reset : 1; unsigned udma33_warned : 1; - unsigned addressing : 2; /* 0=28-bit, 1=48-bit, 2=48-bit doing 28-bit */ + unsigned addressing : 1; /* 0=28-bit, 1=48-bit */ unsigned wcache : 1; /* status of write cache */ unsigned nowerr : 1; /* used for ignoring ATA_DF */